Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a maker is missing packages, interactive runs now list them and ask whether to install them with Composer, instead of failing with the command to run. On "yes" the packages are required (dev ones with
--dev) and the maker is restarted in a new process, since the running kernel was built without them andcomposer requirecorrupts its container cache. On "no", and with--no-interaction, the existing error is unchanged.The restart needs a TTY. Without one (e.g. on Windows), the command stops after the installation and asks to run the maker again.
Only the dependencies declared in
configureDependencies()are covered. Makers that check packages later ininteract()(e.g.make:auth,make:user) keep their current message, which could be a follow-up.Tested in a
symfony/skeleton8.1 app:make:forminstalls form, validator and orm, runs the recipes, restarts and generates the form; declining keeps the error.Fix #1832