doc(security): add firewall lazy option #20459
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This option is (very) briefly mentioned here but I think it would be a good idea to add more specific documentation :) |
MrYamous
reviewed
Dec 10, 2024
| @@ -1075,6 +1075,58 @@ the session must not be used when authenticating users: | |||
| // ... | |||
| }; | |||
|
|
|||
| .. _reference-security-lazy: | |||
There was a problem hiding this comment.
Is that used somewhere or mandatory for any reason ?
There was a problem hiding this comment.
a simple copy/paste from "stateless" doc part for now :s
MrYamous
reviewed
Dec 10, 2024
Comment on lines
+1125
to
+1126
| $mainFirewall = $security->firewall('main'); | ||
| $mainFirewall->lazy(true); |
There was a problem hiding this comment.
Suggested change
| $mainFirewall = $security->firewall('main'); | |
| $mainFirewall->lazy(true); | |
| $security->firewall('main') | |
| ->lazy(true); |
What do you think about this syntax ?
There was a problem hiding this comment.
yes, will cs fix if the PR is accepted and we decide how to document this option :)
indeed, that's the only ref on recent doc, but it feel very related to the doc context, not the security config |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on https://symfony.com/doc/4.x/reference/configuration/security.html, we can see the option anonymous: lazy
on actual maintained version of the doc, https://symfony.com/doc/6.4/reference/configuration/security.html and +
I cant find any reference to lazy
This PR tries to (re)document this option (next to stateless but feel free to challenge)
Please if it was removed on purposes, feel free to close but share a link/PR as I didnt find while searching