[1.x] feat(upgrade): bump codebase to match sylius v[1.12|1.13|1.14] #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
maxperei
commented
Dec 27, 2024
•
maxperei
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | yes |
| Fixed issue | n/a |
| License | MIT |
maxperei
force-pushed
the
feat/migration-sylius-latest-v1
branch
3 times, most recently
from
78c7688 to
643f591
Compare
maxperei
force-pushed
the
feat/migration-sylius-latest-v1
branch
2 times, most recently
from
7a55bcf to
fef29f9
Compare
Jibbarth
reviewed
Dec 30, 2024
| use Synolia\SyliusSchedulerCommandPlugin\Components\Exceptions\Checker\IsNotDueException; | ||
| use Synolia\SyliusSchedulerCommandPlugin\Entity\CommandInterface; | ||
|
|
||
| /** | ||
| * This checker only works if current date/time is checked every minutes | ||
| */ | ||
| #[AutoconfigureTag(IsDueCheckerInterface::TAG_ID)] |
There was a problem hiding this comment.
Let's remove the TAG_ID, and use the IsDueCheckerInterface::class instead ✨
| @@ -10,80 +10,55 @@ | |||
| use Doctrine\ORM\Mapping as ORM; | |||
| use Synolia\SyliusSchedulerCommandPlugin\Repository\CommandRepository; | |||
|
|
|||
| /** | |||
| * @ORM\Entity(repositoryClass="Synolia\SyliusSchedulerCommandPlugin\Repository\CommandRepository") | |||
There was a problem hiding this comment.
This should stay for now IMHO, let's remove them for v2 compatible
There was a problem hiding this comment.
but rector has a clearly different opinion ^^
| use Symfony\Component\OptionsResolver\OptionsResolver; | ||
| use Synolia\SyliusSchedulerCommandPlugin\Humanizer\HumanizerInterface; | ||
| use Twig\Environment; | ||
|
|
||
| final class ScheduledCommandHumanReadableExpressionType implements FieldTypeInterface | ||
| // app.grid_field.scheduled_command.humanReadableExpression |
| { | ||
| public function __construct( | ||
| private readonly KernelInterface $kernel, | ||
| #[Autowire(['_complete'])] |
There was a problem hiding this comment.
I don't see any namespace that could match with this one. I saw it was set in services.yaml, but really weird
| @@ -14,7 +14,7 @@ final class BytesFormatterExtension extends AbstractExtension | |||
| public function getFilters(): array | |||
| { | |||
| return [ | |||
| new TwigFilter('format_bytes', [$this, 'formatBytes']), | |||
| new TwigFilter('format_bytes', $this->formatBytes(...)), | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.