fix: preserve header popup and menu controls on locale changes - #4961
Open
sridharkalaibala wants to merge 1 commit into
Open
sridharkalaibala wants to merge 1 commit into
sridharkalaibala wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Calling
setLocale()replaces the column title HTML, removing the popup and menu buttons inserted into that title. For example, switching an EnglishNameheader to FrenchNomremoves the control used to open a column filter popup.Change
Emit an internal
column-title-renderedevent after formatting the title. The Popup and Menu modules keep their header button references in weak maps and reattach the existing nodes after title updates. This preserves button identity and click handlers, adds no DOM queries to production code, and leaves modules optional.Fixes #4927. The issue's existing JSFiddle demonstrates the original popup behavior; header menus have the same cause.
Validation
git diff --checkpassed.