Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make Jest stop typechecking .spec.ts files before running tests to speed them up #1358

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

verytactical
Copy link
Contributor

@verytactical verytactical commented Jan 16, 2025

Issue

Closes #1366.

Checklist

  • I have updated CHANGELOG.md
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@verytactical verytactical requested a review from a team as a code owner January 16, 2025 16:34
@anton-trunov anton-trunov added this to the v1.6.0 milestone Jan 16, 2025
@anton-trunov anton-trunov self-assigned this Jan 16, 2025
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@anton-trunov
Copy link
Member

Here is the test performance difference observed on my machine for yarn test:

Before this PR

Test Suites: 341 passed, 341 total
Tests:       25 skipped, 6255 passed, 6280 total
Snapshots:   742 passed, 742 total
Time:        30.752 s, estimated 56 s
Ran all test suites.
✨  Done in 31.57s.
yarn test  359.74s user 30.41s system 1226% cpu 31.822 total

After this PR

Test Suites: 341 passed, 341 total
Tests:       25 skipped, 6255 passed, 6280 total
Snapshots:   742 passed, 742 total
Time:        18.423 s, estimated 30 s
Ran all test suites.
✨  Done in 19.36s.
yarn test  169.37s user 13.46s system 934% cpu 19.572 total

@i582
Copy link
Contributor

i582 commented Jan 16, 2025

Wow 🎉

@anton-trunov anton-trunov merged commit 1aaa312 into main Jan 16, 2025
17 checks passed
@anton-trunov anton-trunov deleted the test-perf branch January 16, 2025 17:01
@anton-trunov anton-trunov changed the title refactor: faster tests refactor: make Jest stop typechecking .spec.ts files before running tests to speed them up Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Jest stop typechecking .spec.ts files before running tests to speed them up
3 participants