Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for asm instructions without whitespace #1393

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

xpyctumo
Copy link
Contributor

@xpyctumo xpyctumo commented Jan 20, 2025

Issue

Closes #1268

Checklist

  • I have updated CHANGELOG.md
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

Also, we need fix old parser to handle this tests
UPD: As a solution - tests that only require to use new parser should be placed in src/grammar/test/next/test

@xpyctumo xpyctumo added kind: testing Tests (*.spec.ts) scope: parser Implementation of parser (src/grammar) labels Jan 20, 2025
@xpyctumo xpyctumo added this to the v1.6.0 milestone Jan 20, 2025
@xpyctumo xpyctumo requested a review from a team as a code owner January 20, 2025 08:49
@xpyctumo
Copy link
Contributor Author

Ouch. CI on Windows was failed. Quite a surprise

@reverofevil
Copy link

Ouch. CI on Windows was failed. Quite a surprise

At the moment it's expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: testing Tests (*.spec.ts) scope: parser Implementation of parser (src/grammar)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add grammar tests for whitespace after asm instructions before }
4 participants