chore(deps): updated typescript-eslint
#1425
Conversation
…ssary-template-expression`
| @@ -375,6 +375,7 @@ const parseParens = ({ child }: $ast.Parens): Handler<A.AstExpression> => { | |||
| }; | |||
|
|
|||
| // has to be an interface because of the way TS handles circular type references | |||
| // eslint-disable-next-line @typescript-eslint/no-empty-object-type | |||
| interface Binary extends $ast.Binary<Expression, A.AstBinaryOperation> {} | |||
There was a problem hiding this comment.
That's the error I couldn't beat. As a temporary solution, I suppressed it
There was a problem hiding this comment.
I think it's completely fine to ignore it here, and you did the right thing.
This "empty" type is a workaround for a buggy implementation of recursive types in TS, and linter has no way to know about it.
| : never | ||
| : never; | ||
| type Inputs<I, T extends string> = | ||
| I extends Record<T, infer K> |
There was a problem hiding this comment.
This should be checked manually. In TS a type and alias to the same type are not the same thing, because they implement aliases as instantations, in C++ way.
I'd rather prefer to disable that rule, because it's mostly pointless.
| @@ -6,7 +6,7 @@ | |||
| "target": "esnext" /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019', 'ES2020', 'ES2021', or 'ESNEXT'. */, | |||
| "module": "commonjs" /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', 'es2020', or 'ESNext'. */, | |||
| "lib": ["ESNext"], | |||
| // "allowJs": true, /* Allow javascript files to be compiled. */ | |||
| "allowJs": true /* Allow javascript files to be compiled. */, | |||
There was a problem hiding this comment.
Why do we need this? Tact is TS-only project, and allowJs: false seems to be some kind of a lint.
Issue
Closes #1430.
There will likely be errors on CI that I couldn't catch locally, I'll fix them. Also maybe some of my solutions to errors are not suitable for you, I am ready to fix them.
Checklist