Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move src/optimizer/utils.ts to src/ast/ #1432

Merged
merged 1 commit into from
Jan 20, 2025
Merged

refactor: move src/optimizer/utils.ts to src/ast/ #1432

merged 1 commit into from
Jan 20, 2025

Conversation

i582
Copy link
Contributor

@i582 i582 commented Jan 20, 2025

Issue

Closes #1421.

Checklist

  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@i582 i582 added this to the v1.6.0 milestone Jan 20, 2025
@i582 i582 requested a review from verytactical January 20, 2025 20:08
@i582 i582 requested a review from a team as a code owner January 20, 2025 20:08
@anton-trunov anton-trunov merged commit b8e40b6 into main Jan 20, 2025
17 of 18 checks passed
@anton-trunov anton-trunov deleted the pmakhnev/move-src-optimizer-util-to-src-ast branch January 20, 2025 21:54
@anton-trunov anton-trunov self-assigned this Jan 20, 2025
@verytactical
Copy link
Contributor

@i582 It couldn't be that easy, of course.

There are several stray math functions on the bottom of the file.

We should move them back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

@verytactical verytactical Awaiting requested review from verytactical

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Move src/optimizer/util.ts to src/ast
3 participants
@i582 @verytactical @anton-trunov