Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

%Bigint.prototype.toString% clarification #2860

Closed
bathos opened this issue Aug 16, 2022 · 0 comments · Fixed by #2866
Closed

%Bigint.prototype.toString% clarification #2860

bathos opened this issue Aug 16, 2022 · 0 comments · Fixed by #2866

Comments

@bathos
Copy link
Contributor

bathos commented Aug 16, 2022

Initially the How “implementation-defined” is %Number.prototype.toString% meant to be? issue concerned both %Number.prototype.toString% and %BigInt.prototype.toString%, which followed a common pattern that appeared to permit a degree of behavior divergence among implementations that seemed like it might not be necessary/desirable/intentional.

@michaelficarra brought the question to an editor call which (I’m inferring) resolved to make de facto / implied behavior requirements explicit for %Number.prototype.toString%. This is being achieved by giving Number::toString a new radix parameter and updated algorithmic steps that explain the derivation of non-decimal representations, as can be seen in his corresponding PR (not yet merged at the time of writing this).

As that PR and the related discussion concerned %Number.prototype.toString% / Number::toString only, the “How implementation-defined...” issue should now be regarded as only concerning the Number case too while this new issue captures the related question of whether/how %BigInt.prototype.toString% / BigInt::toString might also be clarified/narrowed. Per @michaelficarra:

Agree, we could do something similar about %Bigint.prototype.toString%. [...] I don't think they should share an algorithm, but we can at least make a similar clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant