Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: clarify BigInt.prototype.toString for non-decimal radices #2866

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Editorial: clarify BigInt.prototype.toString for non-decimal radices #2866

merged 1 commit into from
Sep 1, 2022

Conversation

michaelficarra
Copy link
Member

Fixes #2860. Similar to what we did for Number.prototype.toString in #2854.

/cc @bathos

@michaelficarra michaelficarra requested a review from a team August 20, 2022 03:16
bathos
bathos reviewed Aug 20, 2022
View reviewed changes
spec.html Outdated Show resolved Hide resolved
@michaelficarra michaelficarra requested a review from syg August 29, 2022 23:46
@michaelficarra michaelficarra added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Aug 31, 2022
@ljharb ljharb merged commit 9a5caa4 into main Sep 1, 2022
@ljharb ljharb deleted the GH-2860 branch September 1, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bathos bathos bathos left review comments

@bakkot bakkot bakkot approved these changes

@ljharb ljharb ljharb left review comments

@syg syg Awaiting requested review from syg

Assignees
No one assigned
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

%Bigint.prototype.toString% clarification
4 participants
@michaelficarra @ljharb @bakkot @bathos