Skip to content

Temporal: Test whole- and zero-second offset time zone identifiers - #5164

Merged
ptomato merged 1 commit into
tc39:mainfrom
Manishearth:temporal-sub-minute-offset-tz
Nov 3, 2026
Merged

ptomato merged 1 commit into
tc39:mainfrom
Manishearth:temporal-sub-minute-offset-tz

Conversation

@Manishearth

Copy link
Copy Markdown
Contributor

This is tested in Intl.DateTimeFormat but not in Temporal: you aren't allowed to specify sub-minute offsets within the [timezone] annotation, even if the sub-minute value is zero.

This also covers the different ways of specifying offsets.

@Manishearth
Manishearth requested a review from a team as a code owner November 3, 2026 19:11
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

23 new or modified tests were run on 7 engines.

View workflow run

Test results
Test Engine262 GraalJS JavaScriptCore QuickJS SpiderMonkey V8 XS
built-ins/Temporal/Duration/compare/relativeto-sub-minute-offset.js ✅ ✅ ✅ ❌ ✅ ❌ ❌
built-ins/Temporal/Duration/prototype/round/relativeto-sub-minute-offset.js ✅ ✅ ✅ ❌ ✅ ❌ ❌
built-ins/Temporal/Duration/prototype/total/relativeto-sub-minute-offset.js ✅ ✅ ✅ ❌ ✅ ❌ ❌
built-ins/Temporal/Instant/prototype/toString/timezone-string-sub-minute-offset.js ✅ ✅ ✅ ❌ ✅ ❌ ❌
built-ins/Temporal/Instant/prototype/toZonedDateTimeISO/timezone-string-sub-minute-offset.js ✅ ✅ ✅ ❌ ✅ ❌ ❌
built-ins/Temporal/Now/plainDateISO/timezone-string-sub-minute-offset.js ✅ ✅ ✅ ❌ ✅ ❌ ❌
built-ins/Temporal/Now/plainDateTimeISO/timezone-string-sub-minute-offset.js ✅ ✅ ✅ ❌ ✅ ❌ ❌
built-ins/Temporal/Now/plainTimeISO/timezone-string-sub-minute-offset.js ✅ ✅ ✅ ❌ ✅ ❌ ❌
built-ins/Temporal/Now/zonedDateTimeISO/timezone-string-sub-minute-offset.js ✅ ✅ ✅ ❌ ✅ ❌ ❌
built-ins/Temporal/PlainDate/prototype/toZonedDateTime/timezone-string-sub-minute-offset.js ✅ ✅ ✅ ❌ ✅ ❌ ❌
built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/timezone-string-sub-minute-offset.js ✅ ✅ ✅ ❌ ✅ ❌ ❌
built-ins/Temporal/ZonedDateTime/compare/argument-propertybag-timezone-string-sub-minute-offset.js ✅ ✅ ✅ ❌ ✅ ❌ ❌
built-ins/Temporal/ZonedDateTime/compare/argument-string-sub-minute-offset.js ✅ ✅ ✅ ❌ ✅ ❌ ❌
built-ins/Temporal/ZonedDateTime/from/argument-propertybag-timezone-string-sub-minute-offset.js ✅ ✅ ✅ ❌ ✅ ❌ ❌
built-ins/Temporal/ZonedDateTime/from/argument-string-sub-minute-offset.js ✅ ✅ ✅ ❌ ✅ ❌ ❌
built-ins/Temporal/ZonedDateTime/prototype/equals/argument-propertybag-timezone-string-sub-minute-offset.js ✅ ✅ ✅ ❌ ✅ ❌ ❌
built-ins/Temporal/ZonedDateTime/prototype/equals/argument-string-sub-minute-offset.js ✅ ✅ ✅ ❌ ✅ ❌ ❌
built-ins/Temporal/ZonedDateTime/prototype/since/argument-propertybag-timezone-string-sub-minute-offset.js ✅ ✅ ✅ ❌ ✅ ❌ ❌
built-ins/Temporal/ZonedDateTime/prototype/since/argument-string-sub-minute-offset.js ✅ ✅ ✅ ❌ ✅ ❌ ❌
built-ins/Temporal/ZonedDateTime/prototype/until/argument-propertybag-timezone-string-sub-minute-offset.js ✅ ✅ ✅ ❌ ✅ ❌ ❌
built-ins/Temporal/ZonedDateTime/prototype/until/argument-string-sub-minute-offset.js ✅ ✅ ✅ ❌ ✅ ❌ ❌
built-ins/Temporal/ZonedDateTime/prototype/withTimeZone/timezone-string-sub-minute-offset.js ✅ ✅ ✅ ❌ ✅ ❌ ❌
built-ins/Temporal/ZonedDateTime/timezone-string-sub-minute-offset.js ✅ ✅ ✅ ❌ ✅ ❌ ❌

@ptomato ptomato left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@ptomato
ptomato merged commit c990733 into tc39:main Nov 3, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants