Repository navigation
Conversation
trackoor
force-pushed
the
continue-label-set
branch
from
November 6, 2026 07:58
0bceda0 to
36e1d10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
a: b: for (…) { continue a; }both labels are in the loop's labelSet, so LoopContinues returns true forcontinue aas well ascontinue b. The existing tests (labeled-continue.js,simple-and-labeled.js, …) put a single label on the loop.Engines that got this wrong:
continueto the outer label of a label set (a: b: for (…) continue a;) never terminates boa-dev/boa#5633 (continue are-runs the loop from its initialiser and never terminates)continueto an outer label of a label set (a: b: for (…) continue a;) is rejected with "break/continue label not found" quickjs-ng/quickjs#1884 (fix in Allow 'continue' to an outer label of a loop's label set quickjs-ng/quickjs#1885) and QuickJS:continueto an outer label of a label set (a: b: for (…) continue a;) gives "break/continue label not found" bellard/quickjs#595 (SyntaxError "break/continue label not found")continuetargeting outer label of a multi-labeledforloop (a: b: for (...)) never terminates CanadaHonk/porffor#447labeled-continue-label-set.jscoversfor,while,do-while,for-inandfor-ofwith two or three labels;labeled-continue-label-set-nested.jscontinues an outer loop by either label from an inner loop.Both files pass (sloppy and strict) on V8 15.9.109, SpiderMonkey 160.0b5, JavaScriptCore (macOS 26.3), engine262 67a6b615, GraalJS 25.5.5, XS 17.9.3 and Hermes 0.11.0. Boa nightly (2026-11-06) times out on both; quickjs-ng e22ce4d and QuickJS 712e8c0 throw a SyntaxError.