Repository navigation
Remove unnecessary normalization - #5175
Open
jugglinmike wants to merge 1 commit into
Open
jugglinmike wants to merge 1 commit into
jugglinmike wants to merge 1 commit into
Conversation
Test legibility is improved when the values expressed in the test files match the values being asserted. Because test authors have control over the value in this case (and because the affected tests do not require normalization today), the normalization logic may be safely removed. Refactor the normalization as an enforcement of the contract in order to alert future contributors of that contract and assist them in honoring it.
ljharb
force-pushed
the
remove-unnecessary-normalization
branch
from
November 10, 2026 01:26
6c1e74f to
320b4d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test legibility is improved when the values expressed in the test files match the values being asserted. Because test authors have control over the value in this case (and because the affected tests do not require normalization today), the normalization logic may be safely removed.
Refactor the normalization as an enforcement of the contract in order to alert future contributors of that contract and assist them in honoring it.