Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExpectedArgumentCount does not count a FunctionRestParameter, whatever its binding. The existing tests check
lengthfor a BindingIdentifier rest parameter (expected-argument-count.js), andarray-pattern.jsandobject-pattern.jscover a BindingPattern rest parameter but notlength.Engine that got this wrong:
lengthcounts a rest parameter that is a destructuring pattern quickjs-ng/quickjs#1927 (fix in Don't count a destructuring rest parameter in Function length quickjs-ng/quickjs#1928):(function (a, ...[b]) {}).lengthis 2The test passes (sloppy and strict) on V8 15.7.108, SpiderMonkey 158.0b5, JavaScriptCore 323410, XS (Moddable SDK 9.5.0), GraalJS 25.6.0-dev and quickjs-ng with the fix, and fails on quickjs-ng 0.18.0.