Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementation of translation of bengali #730

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

olumolu
Copy link

@olumolu olumolu commented Oct 12, 2024

No description provided.

Copy link
Owner

@tchx84 tchx84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @olumolu , I left two minor comments.

Thanks for working on this and apologies for the delay.

po/bn.po Outdated Show resolved Hide resolved
po/bn.po Outdated Show resolved Hide resolved
po/bn.po Outdated Show resolved Hide resolved
po/bn.po Outdated Show resolved Hide resolved
po/bn.po Outdated Show resolved Hide resolved
po/bn.po Outdated Show resolved Hide resolved
po/bn.po Outdated Show resolved Hide resolved
po/bn.po Outdated Show resolved Hide resolved
po/bn.po Outdated

#: data/com.github.tchx84.Flatseal.appdata.xml.in:25
msgid "Flatseal showing filesystem permissions"
msgstr "ফ্ল্যাটসিল ফাইল সিস্টেম অনুমতি দেখাচ্ছে"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether you keep it in English or Bengali, just be consistent through all the document.

po/bn.po Outdated Show resolved Hide resolved
Copy link
Owner

@tchx84 tchx84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see places where you translate Flatseal and places where you don't translate Flatseal. I don't really know what's the correct way of doing it for Bengali, but I think it should at least be consistent. So please make it consistent, no matter what you choose.

@olumolu olumolu requested a review from tchx84 December 25, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants