fix #493: strip whitespace from current_query and selection #494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #493
What are the key elements of this solution?
This PR strips whitespace from
editor.current_query
,editor.previous_query
, andapp._validate_selection
, so that the previous query is executed when the current query is only whitespace. The previous behavior was confusing (see issue).Why did you design your solution this way? Did you assess any alternatives? Are there tradeoffs?
The database doesn't care about whitespace, so it's better to strip it than add new logic with
isspace
, etc.Does this PR require a change to Harlequin's docs?
Did you add or update tests for this change?
Please complete the following checklist:
CHANGELOG.md
, under the[Unreleased]
section heading. That entry references the issue closed by this PR.