Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixclipboarderror #510

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Fixclipboarderror #510

merged 3 commits into from
Apr 11, 2024

Conversation

bjornasm
Copy link
Contributor

@bjornasm bjornasm commented Apr 11, 2024

on_text_area_clipboard_error is linking to https://harlequin.sh/docs/troubleshooting#copying-and-pasting but that link is dead, and https://harlequin.sh/docs/troubleshooting/copying-and-pasting is correct.

Closes (#509) (an existing open issue)

What are the key elements of this solution?
Switched to the correct link.

Why did you design your solution this way? Did you assess any alternatives? Are there tradeoffs?
Not appliccable.

Does this PR require a change to Harlequin's docs?

  • No.
  • Yes, and I have opened a PR at tconbeer/harlequin-web.
  • Yes; I haven't opened a PR, but the gist of the change is: ...

Did you add or update tests for this change?

  • Yes.
  • No, I believe tests aren't necessary.
  • No, I need help with testing this change.

Please complete the following checklist:

  • I have added an entry to CHANGELOG.md, under the [Unreleased] section heading. That entry references the issue closed by this PR.
  • I acknowledge Harlequin's MIT license. I do not own my contribution.

Copy link
Owner

@tconbeer tconbeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this!

@tconbeer tconbeer merged commit ade6c8c into tconbeer:main Apr 11, 2024
10 checks passed
@bjornasm bjornasm deleted the fixclipboarderror branch April 11, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants