Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add NO_COLOR support to the config wizard #678

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

tconbeer
Copy link
Owner

@tconbeer tconbeer commented Oct 31, 2024

Closes #552

What are the key elements of this solution?
We check the NO_COLOR env var before setting the colors/style for the config app.

Why did you design your solution this way? Did you assess any alternatives? Are there tradeoffs?
Considered deeper support, including a HARLEQUIN_NO_COLOR variable, but it didn't seem necessary. Textual and rich-click already have robust NO_COLOR support.

Does this PR require a change to Harlequin's docs?

  • No.
  • Yes, and I have opened a PR at tconbeer/harlequin-web.
  • Yes; I haven't opened a PR, but the gist of the change is: we should note that we support NO_COLOR somewhere.

Did you add or update tests for this change?

  • Yes.
  • No, I believe tests aren't necessary. (the config app doesn't have any tests -- I tested this manually.)
  • No, I need help with testing this change.

Please complete the following checklist:

  • I have added an entry to CHANGELOG.md, under the [Unreleased] section heading. That entry references the issue closed by this PR.
  • I acknowledge Harlequin's MIT license. I do not own my contribution.

@tconbeer tconbeer enabled auto-merge (squash) October 31, 2024 20:26
@tconbeer tconbeer merged commit 60c2e46 into main Oct 31, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make --config support NO_COLOR
1 participant