Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop deprecated parameters from vectorize.table() #158

Merged
merged 11 commits into from
Oct 29, 2024
Merged

drop deprecated parameters from vectorize.table() #158

merged 11 commits into from
Oct 29, 2024

Conversation

Bhavyajain21
Copy link
Contributor

/fixes #146
/claim #146

@algora-pbc algora-pbc bot mentioned this pull request Oct 17, 2024
Closed
@ChuckHend
Copy link
Member

vectorize.search() and vectorize.table() need to remain functional after the deprecated params are dropped, so there could be some scope related to updating the call tree such that it only uses the index_dist_type parameter.

@Bhavyajain21
Copy link
Contributor Author

I've updated the PR. Can you please review? @ChuckHend

@ChuckHend
Copy link
Member

FYI - image builds will fail because the branch is outside the Tembo org, and that is fine.

@ChuckHend ChuckHend mentioned this pull request Oct 28, 2024
Closed
@ChuckHend ChuckHend merged commit 18d95ff into tembo-io:main Oct 29, 2024
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuckHend ChuckHend ChuckHend approved these changes

@jasonmp85 jasonmp85 Awaiting requested review from jasonmp85

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

drop deprecated parameters from vectorize.table()
2 participants
@Bhavyajain21 @ChuckHend