-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chunking support to vectorize.table() #162
base: main
Are you sure you want to change the base?
Conversation
@ChuckHend Have a look at your free time and kindly approve workflows, if any adjustments needed i am happy to incorporate them |
Waiting for a quick review on this too - @ChuckHend |
@ChuckHend Any changes needed here? |
I might need to provide further clarification in the issue. What is intended is that when calling |
@ChuckHend Updated the changes with intended approach of chunking Have a review on it and If any changes or modifications required I am ready to incorporate them |
@ChuckHend Have a review on it in your free time |
Can you add a test or two that shows how the functionality will work and assert that it functions as expected? |
Sure! I will update the tests |
Just a minor query just does we need automatic chunking once table is
called and it sync with chunk_table?
…On Mon, 4 Nov, 2024, 8:43 pm Adam Hendel, ***@***.***> wrote:
Can you add a test or two that shows how the functionality will work and
assert that it functions as expected?
—
Reply to this email directly, view it on GitHub
<#162 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BGXZB6GUWQYZTX2ZY75W7ATZ656JHAVCNFSM6AAAAABQEOKG32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJUHE3TOMBWGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Yes, let's leave the integration with |
Okay! |
Just need test update and I am confused of I am going in right way of testing that function @ChuckHend |
Closes #142
/claim #142