Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chunking support to vectorize.table() #162

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

asr2003
Copy link
Contributor

@asr2003 asr2003 commented Oct 17, 2024

Closes #142
/claim #142

@asr2003
Copy link
Contributor Author

asr2003 commented Oct 17, 2024

@ChuckHend Have a look at your free time and kindly approve workflows, if any adjustments needed i am happy to incorporate them

@asr2003
Copy link
Contributor Author

asr2003 commented Oct 18, 2024

Waiting for a quick review on this too - @ChuckHend

@asr2003
Copy link
Contributor Author

asr2003 commented Oct 19, 2024

@ChuckHend Any changes needed here?

@ChuckHend
Copy link
Member

I might need to provide further clarification in the issue. What is intended is that when calling vectorize.table() on an existing table, each row is split into multiple 'chunks' (one new row for each chunk). I think these new rows will need to live on a separate table.

@asr2003
Copy link
Contributor Author

asr2003 commented Oct 23, 2024

@ChuckHend Updated the changes with intended approach of chunking vectorie.table by retreiving rows and lives into new table,

Have a review on it and If any changes or modifications required I am ready to incorporate them

@asr2003
Copy link
Contributor Author

asr2003 commented Oct 26, 2024

@ChuckHend Have a review on it in your free time

@ChuckHend
Copy link
Member

Can you add a test or two that shows how the functionality will work and assert that it functions as expected?

@asr2003
Copy link
Contributor Author

asr2003 commented Nov 6, 2024

Sure! I will update the tests

@asr2003
Copy link
Contributor Author

asr2003 commented Dec 13, 2024 via email

@ChuckHend
Copy link
Member

Yes, let's leave the integration with vectorize.table() out to make this simpler / easier. Just keep chunk_text() a sql function that we can call directly, and add a couple tests that validate its functionality and shows how to use it.

@asr2003
Copy link
Contributor Author

asr2003 commented Dec 20, 2024

Okay!

@asr2003
Copy link
Contributor Author

asr2003 commented Dec 29, 2024

Just need test update and I am confused of I am going in right way of testing that function @ChuckHend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chunking support to vectorize.table()
2 participants