-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement event trigger to remove jobs from vectorize.job upon table deletion #164
Closed
Closed
Changes from 14 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
dda517c
feat: add event trigger to delete jobs from vectorize.job when tables…
varshith257 f837b6b
fmt
varshith257 3424116
feat: add event trigger to delete jobs from vectorize.job when tables…
varshith257 748311a
fmt
varshith257 a6b9886
fmt
varshith257 4ba0836
test: event trigger deletion adeed
varshith257 dd9dda4
Merge branch 'chore-jobs' of https://github.com/varshith257/pg_vector…
varshith257 71521a6
Merge branch 'main' into chore-jobs
ChuckHend 9a90853
feat: add review suggestions
varshith257 b28267d
fmt
varshith257 25caa22
Merge branch 'chore-jobs' of https://github.com/varshith257/pg_vector…
varshith257 c723c4a
Merge branch 'main' into chore-jobs
varshith257 df58e4b
Merge branch 'main' into chore-jobs
ChuckHend 4781af4
fix test
varshith257 2d8ccb0
Merge branch 'main' into chore-jobs
ChuckHend 16eb56c
update test to use vectorize.table
varshith257 f7d689d
Merge branch 'chore-jobs' of https://github.com/varshith257/pg_vector…
varshith257 64ae4fc
use CASCADE to drop all dependencies conflicting to DROP TABLE
varshith257 db0a475
Merge branch 'main' into chore-jobs
ChuckHend f211b32
fix tests
varshith257 79771f6
Merge branch 'main' into chore-jobs
varshith257 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a
select vectorize.table(...)
instead, so that the test stays current with the APIs around that table.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@varshith257 - i think replace this direct insert with
vectorize.table()
. It should help the test move along as it is currently failing because the search_alg column no longer exists (it was removed from the project).