Skip to content

Commit

Permalink
remove references to LFS (#16722)
Browse files Browse the repository at this point in the history
### Tickets
Closes #2723
Closes #4435

### Problem description
We get charged $$$$ for LFS usage, LFS clone has introduced intermittent
failures in CI, and it adds complexity to our install process.

### What's changed
Goodbye LFS

### Checklist
- [x] Post commit CI passes
- [ ] Blackhole Post commit (if applicable)
- [ ] Model regression CI testing passes (if applicable)
- [ ] Device performance regression CI testing passes (if applicable)
- [ ] **(For models and ops writers)** Full [new
models](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml)
tests passes
- [ ] New/Existing tests provide coverage for changes
  • Loading branch information
TT-billteng authored Jan 15, 2025
1 parent 1600fd6 commit 76ce6c7
Show file tree
Hide file tree
Showing 13 changed files with 6 additions and 284 deletions.
7 changes: 2 additions & 5 deletions .github/actions/checkout-with-submodule-lfs/action.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: "Checkout recursively with submodules and LFS"
name: "Checkout recursively with submodules"
description: "Installs tt-metal extra dev dependencies on ubuntu-20.04 GitHub Actions runners"

inputs:
Expand Down Expand Up @@ -27,12 +27,9 @@ runs:
with:
token: ${{ inputs.token }}
fetch-depth: ${{ inputs.fetch-depth }}
lfs: true
lfs: false
submodules: recursive
clean: true
- name: Clean each submodule
shell: bash
run: git submodule foreach 'git clean -xffd'
- name: Fetch and pull LFS objects for each submodule
shell: bash
run: git submodule foreach 'git lfs fetch && git lfs pull'
4 changes: 1 addition & 3 deletions .github/actions/install-metal-dev-deps/dependencies.json
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
{
"_comments": "We do not include git and git-lfs here along with the PPA command 'sudo add-apt-repository ppa:git-core/ppa' for registering the apt repository to install those packages because we were timing out the GPG fetching by hammering it",
"_comments": "We do not include git here along with the PPA command 'sudo add-apt-repository ppa:git-core/ppa' for registering the apt repository to install those packages because we were timing out the GPG fetching by hammering it",
"ubuntu-20.04": [
"git",
"git-lfs",
"pandoc",
"pkg-config",
"ninja-build"
],
"ubuntu-22.04": [
"git",
"git-lfs",
"pandoc",
"pkg-config",
"ninja-build",
Expand Down
3 changes: 0 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,6 @@ venv/
# releases
dist

# exclude dtx generated files
tt_metal/third_party/lfs/dtx_transform_outputs

#exclude reports dir
.reports/*

Expand Down
3 changes: 0 additions & 3 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
[submodule "third_party/lfs"]
path = tt_metal/third_party/lfs
url = https://github.com/tenstorrent-metal/lfs.git
[submodule "tt_metal/third_party/taskflow"]
path = tt_metal/third_party/taskflow
url = https://github.com/taskflow/taskflow
Expand Down
12 changes: 2 additions & 10 deletions INSTALLING.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,21 +48,13 @@ sudo ./install_dependencies.sh
> If you do not want to use the models or follow the tutorials and want to
> immediately start using the API, you may install just the wheel or get the release Docker container.
1. Install git and git-lfs.

```sh
sudo apt install git git-lfs
```

2. Clone the repo.
1. Clone the repo.

```sh
git clone https://github.com/tenstorrent/tt-metal.git --recurse-submodules
cd tt-metal
git submodule foreach 'git lfs fetch --all && git lfs pull'
```

3. Install either from source, or from our release wheel. Note that if you are
2. Install either from source, or from our release wheel. Note that if you are
going to try using the model demos, we highly recommend you install from
source.

Expand Down
1 change: 0 additions & 1 deletion install_dependencies.sh
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ ub_package_list()
{
UB_LIST=(\
git \
git-lfs \
build-essential \
cmake \
software-properties-common \
Expand Down
1 change: 0 additions & 1 deletion models/demos/t3000/llama3_70b/setup_llama.sh
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@ check_and_build_tt_metal() {
if [[ ! -d "python_env" ]]; then
git checkout "${TT_METAL_COMMIT_SHA_OR_TAG}"
git submodule update --init --recursive
git submodule foreach 'git lfs fetch --all && git lfs pull'
./build_metal.sh
./create_venv.sh
source python_env/bin/activate
Expand Down
249 changes: 0 additions & 249 deletions models/experimental/synthetic_gradients/tt/sg_mnist.py

This file was deleted.

1 change: 0 additions & 1 deletion scripts/docker/requirements-20.04.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ dialog
software-properties-common=0.99.9.12
build-essential=12.8ubuntu1.1
git
git-lfs
pandoc
libtbb-dev
libcapstone-dev
Expand Down
1 change: 0 additions & 1 deletion scripts/docker/requirements-22.04.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ build-essential
gcc-12
g++-12
git
git-lfs
pandoc
libtbb-dev
libcapstone-dev
Expand Down
6 changes: 1 addition & 5 deletions tt-train/.github/workflows/builld_and_test_all.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,7 @@ jobs:
- uses: actions/checkout@v4
with:
submodules: recursive
lfs: true

- name: LFS pull
run: |
git submodule foreach --recursive git lfs pull
lfs: false

# actions/checkout runs `git clean -ffdx && git reset --hard HEAD` before fetching
# but `build`, `build_Release`, `built` (contains compiled kernels) dirs are not removed because they are in .gitignore
Expand Down
1 change: 0 additions & 1 deletion tt-train/init_repo.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
# SPDX-License-Identifier: Apache-2.0

# Description: Initialize the repository with the necessary configurations
git lfs install
sudo apt install clang-tidy-17
sudo apt install clang-format-17
sudo ln -sf /usr/bin/clang-tidy-17 /usr/bin/clang-tidy
Expand Down
1 change: 0 additions & 1 deletion tt_metal/third_party/lfs
Submodule lfs deleted from e82667

0 comments on commit 76ce6c7

Please sign in to comment.