Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix failed elixir tests #3428

Merged
merged 5 commits into from
Nov 16, 2023
Merged

ci: Fix failed elixir tests #3428

merged 5 commits into from
Nov 16, 2023

Conversation

NirKli
Copy link
Contributor

@NirKli NirKli commented Nov 14, 2023

It seems to solve the failing tests on my local machine but I would like to try to re-run the action that failed in master.
@DrMichael @Dulanic
Can one of you, re-run the action is master?

@Dulanic Dulanic marked this pull request as ready for review November 14, 2023 21:49
@Dulanic
Copy link
Collaborator

Dulanic commented Nov 14, 2023

Test running

@NirKli
Copy link
Contributor Author

NirKli commented Nov 15, 2023

@Dulanic
Copy link
Collaborator

Dulanic commented Nov 15, 2023

Test running

This one.

https://github.com/teslamate-org/teslamate/actions/runs/6857820361

My bad, rerunning.

Edit: It failed first time, but then succeeded the 2nd time.

@JakobLichterfeld JakobLichterfeld changed the title Fix failed tests ci: Fix failed elixir tests Nov 16, 2023
@JakobLichterfeld JakobLichterfeld added the elixir Pull requests that update Elixir code label Nov 16, 2023
@JakobLichterfeld JakobLichterfeld merged commit c00dbaa into teslamate-org:master Nov 16, 2023
2 checks passed
@NirKli
Copy link
Contributor Author

NirKli commented Nov 16, 2023

Test running

This one.
https://github.com/teslamate-org/teslamate/actions/runs/6857820361

My bad, rerunning.

Edit: It failed first time, but then succeeded the 2nd time.
@Dulanic @JakobLichterfeld
I wanted to send this message this morning, but I haven't had the chance to.
It seems to me that it's a CI issue and not a test issue.

JakobLichterfeld added a commit that referenced this pull request Nov 16, 2023
JakobLichterfeld added a commit that referenced this pull request Nov 16, 2023
@JakobLichterfeld
Copy link
Collaborator

JakobLichterfeld commented Nov 16, 2023

My bad, reverted with #3440

JakobLichterfeld pushed a commit that referenced this pull request Feb 9, 2024
JakobLichterfeld added a commit that referenced this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elixir Pull requests that update Elixir code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants