-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Build PR images on GHCR #3445
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakobLichterfeld
added
the
github_actions
Pull requests that update Github_actions code
label
Nov 19, 2023
JakobLichterfeld
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks again for the refactoring and the new workflow!
This is awesome! |
Yeah, I thought the same thing, one step at a time. |
1 task
JakobLichterfeld
pushed a commit
that referenced
this pull request
Feb 9, 2024
* Upgrade CI * Tmp Test * Test tmp * Test master * Distinct cache by branch * Correct version name * Dynamic dockerhub push * correct cache name --------- Co-authored-by: Julien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified the CI so that the PR images are build then pushed into the GitHub packages (GHCR).
This does not interfere with how current CI works with Docker Hub.
Functioning :
Once this PR is merged, each new / updated PR will trigger CI on the fork repo.
If necessary, anyone can then modify their docker-compose to use a PR image (eg:
ghcr.io/jlestel/teslamate:master
) for testing this PR instead ofteslamate/teslamate:latest
.After the first run, packages are created in the user repo but images can't be pushed to this user repo.
Each user which want to build his images needs to :
teslamate
andteslamate/grafana
settings and add theuser/teslamate
repository withread/write
permissions.