Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI with PR sources #3479

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Conversation

jlestel
Copy link
Contributor

@jlestel jlestel commented Nov 22, 2023

In fact the pull_request_target event only plays the CI with the destination branch. This does not embed the changes made by the PR.

I modified the action to pull sources from the PR if necessary so that I can offer images per PR in the packages in this repo.

Besides, we could only trigger this pull_request_target when you set certain labels to control what is build.

PS: I added CI branch to the pull_request_target in order to test it on the CI branch.

@JakobLichterfeld JakobLichterfeld added the github_actions Pull requests that update Github_actions code label Nov 22, 2023
Copy link
Collaborator

@JakobLichterfeld JakobLichterfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JakobLichterfeld JakobLichterfeld merged commit 8f5119f into teslamate-org:ci Nov 22, 2023
@jlestel jlestel deleted the ci_with_pr_source branch November 22, 2023 08:14
JakobLichterfeld added a commit that referenced this pull request Nov 27, 2023
* ci: workflow run on ci branch for debuging

* Run CI with PR sources (#3479)

* Run CI with PR sources

* Add CI branch to the pull_request_target

---------

Co-authored-by: Julien <[email protected]>

* GHCR Purge success even if package doesn't exist (#3480)

* GHCR Purge success even if package doesn't exist

* Add CI branch to pull_request_target

* typo

---------

Co-authored-by: Julien <[email protected]>

* Update VERSION to test CI (#3481)

---------

Co-authored-by: jlestel <[email protected]>
Co-authored-by: Julien <[email protected]>
JakobLichterfeld added a commit that referenced this pull request Feb 9, 2024
* ci: workflow run on ci branch for debuging

* Run CI with PR sources (#3479)

* Run CI with PR sources

* Add CI branch to the pull_request_target

---------

Co-authored-by: Julien <[email protected]>

* GHCR Purge success even if package doesn't exist (#3480)

* GHCR Purge success even if package doesn't exist

* Add CI branch to pull_request_target

* typo

---------

Co-authored-by: Julien <[email protected]>

* Update VERSION to test CI (#3481)

---------

Co-authored-by: jlestel <[email protected]>
Co-authored-by: Julien <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants