Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix agressive switch to offline when stream gets offline message #3672

Merged
merged 2 commits into from
Mar 16, 2024

Conversation

micves
Copy link
Contributor

@micves micves commented Feb 13, 2024

Initiated by #3658

When stream got a message that the vehicle was offline, it switched directly to Start / :offline
This is to aggressive and does not reflect the true state of the vehicle

Now its changed to just fetch data right way and let the result handle the true state of the vehicle.

…de the real state instead of switching directly to offline.
Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit f89032c
🔍 Latest deploy log https://app.netlify.com/sites/teslamate/deploys/65cfd9fae2099c0008f8e210
😎 Deploy Preview https://deploy-preview-3672--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@micves micves marked this pull request as draft February 13, 2024 21:22
@JakobLichterfeld JakobLichterfeld added enhancement New feature or request area:teslamate Related to TeslaMate core labels Feb 15, 2024
@micves micves marked this pull request as ready for review February 17, 2024 11:09
@micves
Copy link
Contributor Author

micves commented Mar 8, 2024

I think this is ready for merge, based on results in #3658

Copy link
Collaborator

@JakobLichterfeld JakobLichterfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JakobLichterfeld JakobLichterfeld merged commit 46b9710 into teslamate-org:master Mar 16, 2024
12 checks passed
@jheredianet
Copy link
Contributor

jheredianet commented Mar 25, 2024

I was testing this in varios scenarios and it does not seem to work well. When the car goes to asleep state it directly becomes offline as commented here #3658 (comment).
Maybe for newer updates on Tesla state asleep is offline? I'm not sure.

This is what is happening:

image

@micves micves deleted the stream_detect_offline2 branch March 25, 2024 14:46
@micves
Copy link
Contributor Author

micves commented Mar 25, 2024

This fix just gets the state directly from the car (Tesla api server) so it would not look different.
I'm guessing you are on Tesla version 2024.8.4? Which in generel seems to report asleep as offline.

@jheredianet
Copy link
Contributor

This fix just gets the state directly from the car (Tesla api server) so it would not look different. I'm guessing you are on Tesla version 2024.8.4? Which in general seems to report asleep as offline.

Yes, I'm on version 2024.8.4.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:teslamate Related to TeslaMate core enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants