-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix agressive switch to offline when stream gets offline message #3672
Fix agressive switch to offline when stream gets offline message #3672
Conversation
…de the real state instead of switching directly to offline.
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I think this is ready for merge, based on results in #3658 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I was testing this in varios scenarios and it does not seem to work well. When the car goes to asleep state it directly becomes offline as commented here #3658 (comment). This is what is happening: |
This fix just gets the state directly from the car (Tesla api server) so it would not look different. |
Yes, I'm on version 2024.8.4. |
Initiated by #3658
When stream got a message that the vehicle was offline, it switched directly to Start / :offline
This is to aggressive and does not reflect the true state of the vehicle
Now its changed to just fetch data right way and let the result handle the true state of the vehicle.