-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish extra active_route fields to mqtt output #3789
Conversation
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
d72386f
to
d924ec7
Compare
On my box I am seeing 5 test failures. I imagine I broke something, but don't have time to check right now. |
d924ec7
to
712de83
Compare
Looks like there is an error in the documentation also. |
Looks like CI tests agree with my tests, there are 5 tests failing. Looks like the same tests are failing also. |
712de83
to
7e9ba5d
Compare
Tests now passing. Seems to be a problem with building the docs. |
2d38ba9
to
d9742e5
Compare
Made some changes.
Wondering if we still need the |
d9742e5
to
3e05f68
Compare
RE: changes to reset active_route_ topics when not actually routing RE: adding extra active_route topics RE: adding JSON topics I'm not sure if the goal is to eventually deprecate the separate topics, if so we should update the MQTT and Home Assistant (although I just realised I forgot to update this for the active route sensors) documentations. |
I just removed the new non-json topics in favour of the json topics. And marked the old topics as deprecated in the docs. |
I haven't tested this yet - apart from the CI tests, I imagine that will be the next step :-) |
4ced27c
to
ecd67c0
Compare
Dump of all published values on start, hopefully nothing is missing :-)
I censored latitude, longitude; I don't particularly want to publish the location of my home. Next step will be to dump the values when navigiating. |
This refactors the existing code to make it more maintainable. Nil values are published as "nil" string. This ensures that they will get published, and ensures that MQTT doesn't drop the retained data. Fixes #3748
ecd67c0
to
3cbabf9
Compare
Finally got around to looking at the new topic when car is navigating. Everything looks good to me. If no objections, will merge tomorrow. |
This refactors the existing code to make it more maintainable.
Nil values are published as "nil" string. This ensures that they will get published, and ensures that MQTT doesn't drop the retained data.
This is WIP because it hasn't had any testing yet, and is likely to fail even the CI tests :-)
Fixes #3748