Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: align TPMS Pressure naming in sensor config to match ui config for home assistant #4104

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

helmo
Copy link
Contributor

@helmo helmo commented Jul 27, 2024

#3613 and #3718 modified the TPMS Pressure sensor naming, but part of is was still inconsistent.

this should match the names of the mqtt sensors with the calculated sensors (for psi)

Copy link

netlify bot commented Jul 27, 2024

Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit eb1c045
🔍 Latest deploy log https://app.netlify.com/sites/teslamate/deploys/66a545a1dca9890008d11061
😎 Deploy Preview https://deploy-preview-4104--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JakobLichterfeld JakobLichterfeld added the enhancement New feature or request label Jul 28, 2024
@JakobLichterfeld
Copy link
Collaborator

Thank you for your PR. The names in Home Assistant do not need to match the names of the MQTT topic name, innit?

@JakobLichterfeld JakobLichterfeld changed the title Correct TPMS Pressure naming doc: change TPMS Pressure naming in home assistant Jul 28, 2024
@helmo
Copy link
Contributor Author

helmo commented Jul 28, 2024

Correct mqtt name can be different, but the config to map that to an entity should have the same name as the ui dashboard config.

@JakobLichterfeld
Copy link
Collaborator

Thanks, now I see the mismatch. Good catch!

@JakobLichterfeld JakobLichterfeld changed the title doc: change TPMS Pressure naming in home assistant doc: align TPMS Pressure naming in sensor config to match ui config for home assistant Jul 29, 2024
@JakobLichterfeld JakobLichterfeld merged commit 94da8f6 into teslamate-org:master Jul 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants