Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: exclude streaming data in visited dashboard #4287

Conversation

swiffer
Copy link
Contributor

@swiffer swiffer commented Oct 20, 2024

exclude streaming data in visited dashboard as well. query has been found to be "slow" by checking pg_stat_statements.

as data is bucketed by minute and non streaming data is gathered every 15 seconds i see no reason not to do. greatly reduces query time.

i just want to mention one discussion around a similar change (index on odometer) back from april #3801 where @DrMichael voted against adding this index.

i still think it's right to add it based on all the improvements making it into this release.

@JakobLichterfeld - last PR from my end. voting to include these and cutting a release afterwards.

Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit ce941d3
🔍 Latest deploy log https://app.netlify.com/sites/teslamate/deploys/6714bca5da3be000089cc7e5
😎 Deploy Preview https://deploy-preview-4287--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JakobLichterfeld JakobLichterfeld added enhancement New feature or request area:dashboard Related to a Grafana dashboard labels Oct 20, 2024
@DrMichael
Copy link
Collaborator

i just want to mention one discussion around a similar change (index on odometer) back from april #3801 where @DrMichael voted against adding this index.

Ah, it wasn't me. I would never dare to judge about indexes... :-)

@swiffer
Copy link
Contributor Author

swiffer commented Oct 21, 2024

Yes, right. Sorry it was @Dulanic

Copy link
Collaborator

@JakobLichterfeld JakobLichterfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! Tested successfully on slow HW.

@swiffer
Copy link
Contributor Author

swiffer commented Oct 21, 2024

i think it's good to merge - the discussion related to the index is not part of this PR. if @Dulanic has concerns over the index (that is already added) please open an issue for that.

@JakobLichterfeld JakobLichterfeld merged commit 4d348a1 into teslamate-org:master Oct 21, 2024
15 checks passed
@swiffer swiffer deleted the perf-exclude-streaming-data-in-visited-dashboard branch October 21, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dashboard Related to a Grafana dashboard enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants