-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Fixing typo for sensor psi calculation #4470
Conversation
The psi sensors were not referencing the correct sensor for their calculation.
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks a lot for this beautiful project btw. |
Thank you for your contribution! @longzheng may I ask you for review, as it was latest edited in #4257 by you? |
This change looks good. However this just reminded me perhaps using a template sensor to offer sensors in different units is not the best approach here. Perhaps we can use MQTT sensors with a value template to do the transformations. The benefits would be:
I'll open a separate PR for that change. |
Perfect, ty.
That sounds really like the best way forward, thanks in advance! |
This reverts commit 33ca94a.
The psi sensors were not referencing the correct sensor for their calculation.