Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Fixing typo for sensor psi calculation #4470

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

Phazz
Copy link
Contributor

@Phazz Phazz commented Jan 4, 2025

The psi sensors were not referencing the correct sensor for their calculation.

The psi sensors were not referencing the correct sensor for their calculation.
Copy link

netlify bot commented Jan 4, 2025

Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit 806205c
🔍 Latest deploy log https://app.netlify.com/sites/teslamate/deploys/6779268d3a578d00088fad83
😎 Deploy Preview https://deploy-preview-4470--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Phazz
Copy link
Contributor Author

Phazz commented Jan 4, 2025

Thanks a lot for this beautiful project btw.

@JakobLichterfeld JakobLichterfeld added the kind:documentation Adds or improves documentation label Jan 4, 2025
@JakobLichterfeld
Copy link
Collaborator

JakobLichterfeld commented Jan 4, 2025

Thank you for your contribution!

@longzheng may I ask you for review, as it was latest edited in #4257 by you?

@longzheng
Copy link
Contributor

This change looks good.

However this just reminded me perhaps using a template sensor to offer sensors in different units is not the best approach here. Perhaps we can use MQTT sensors with a value template to do the transformations. The benefits would be:

  • remove sensor reference by entity ID
  • reduce has_value logic in value template
  • have device association

I'll open a separate PR for that change.

@JakobLichterfeld
Copy link
Collaborator

This change looks good.

Perfect, ty.

However this just reminded me perhaps using a template sensor to offer sensors in different units is not the best approach here. Perhaps we can use MQTT sensors with a value template to do the transformations. The benefits would be:

  • remove sensor reference by entity ID
  • reduce has_value logic in value template
  • have device association

I'll open a separate PR for that change.

That sounds really like the best way forward, thanks in advance!

@JakobLichterfeld JakobLichterfeld merged commit 33ca94a into teslamate-org:master Jan 6, 2025
15 checks passed
JakobLichterfeld added a commit that referenced this pull request Jan 6, 2025
JakobLichterfeld added a commit that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:documentation Adds or improves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants