Repository navigation
Fix boolean inputs, duplicate --debug and credential leakage - #31
Open
jochen-testingbot wants to merge 1 commit into
Open
jochen-testingbot wants to merge 1 commit into
jochen-testingbot wants to merge 1 commit into
Conversation
- Flag inputs (shared, noBump, noCache, noProxy, debug, doctor) set to 'false' no longer enable the flag; invalid values fail with a clear error - --debug is only passed once when both the debug input and runner debug mode are enabled - auth and proxyCredentials are masked and forwarded via TESTINGBOT_AUTH / TESTINGBOT_PROXY_USERPWD env vars instead of CLI args, so they no longer show up in docker inspect / ps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First PR in a series. Merge in order: each one is based on the previous branch, so later PRs show only their own changes once this one is merged.
Bugs fixed
shared: falsestill passed--shared(same fornoBump,noCache,noProxy,debuganddoctor). Flags are now parsed likecore.getBooleanInput:true/false(any case), empty means off. Anything else fails with a clear error instead of silently turning the option on.--debugcould be passed twice, once from thedebuginput and once from runner debug mode.authandproxyCredentialsleaked. They were passed as CLI args, so they showed up indocker inspectandpsand were never masked in the workflow log. They're now registered withsetSecretand forwarded with-e TESTINGBOT_AUTH/-e TESTINGBOT_PROXY_USERPWD(value taken from docker's own environment, not the command line).Compatibility
The
TESTINGBOT_AUTH/TESTINGBOT_PROXY_USERPWDenv vars need tunnel 4.8 or newer. The defaulttbVersion: latestis fine; anyone pinningtbVersionbelow 4.8 who uses these two inputs would lose them. The README notes this.Tests
New unit tests cover flags set to
false, invalid boolean values, the--debugdedupe,buildSecretEnv, and the env forwarding instartTunnel.npm test: 29 passing.dist/is rebuilt.