simplified checked input checked attribute and moved logic into subtr…

…actDates function
the-collab-lab · Feb 27, 2024 · b5c18cb · b5c18cb
1 parent 9630a19
commit b5c18cb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/src/components/ListItem.jsx b/src/components/ListItem.jsx
@@ -21,11 +21,7 @@ export function ListItem({ name, listPath, id, dateLastPurchased }) {
 					type="checkbox"
 					name={name}
 					onChange={handleChecked}
-					checked={
-						dateLastPurchased && subtractDates(todaysDate, dateLastPurchased)
-							? true
-							: false
-					}
+					checked={subtractDates(todaysDate, dateLastPurchased)}
 				></input>
 			</label>
 		</li>

diff --git a/src/utils/dates.js b/src/utils/dates.js
@@ -22,7 +22,10 @@ function convertTimestamp(timestamp) {
 }
 
 export function subtractDates(todaysDate, dateLastPurchased) {
-	const dateForCompare = convertTimestamp(dateLastPurchased);
+	if (dateLastPurchased) {
+		const dateForCompare = convertTimestamp(dateLastPurchased);
 
-	return todaysDate.getTime() - dateForCompare < ONE_DAY_IN_MILLISECONDS;
+		return todaysDate.getTime() - dateForCompare < ONE_DAY_IN_MILLISECONDS;
+	}
+	return false;
 }