27. App info modal #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit a5beeb4): https://tcl-66-smart-shopping-list--pr62-an-issue-27-8sui0olu.web.app (expires Thu, 11 Apr 2024 03:45:09 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2dc16cb2a79cbd6723fdc511b73e0743df1d18d0 |
jeremiahfallin
requested changes
Apr 4, 2024
There was a problem hiding this comment.
It looks good and works well but 2 things:
-
Modals should be closeable using the ESC key for accessibility:
https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/ -
This isn't required to fix and more of an FYI, but it looks slightly wonky in Chrome on Windows:
jeremiahfallin
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
closes #61
Acceptance Criteria
Type of Changes
accessibility, enhancement
Updates
Before
After
Screen.Recording.2024-04-03.at.7.05.56.PM.mov
Testing Steps / QA Criteria
Notes
I am not set in stone with the exact verbiage used. So if you want it to be said in a different way, feel free to let me know! I just used AI to help me come up with the wording.