Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Firebase config keys and replace signInWithRedirect with signInWithPopup in useAuth hook #15

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

ahsanatzapier
Copy link
Collaborator

Description

In this PR, I replaced the signInWithRedirect method with signInWithPopup in the useAuth hook. Additionally, I updated config.js with the required Firebase config keys, which is part of the initial setup for our project.

Acceptance Criteria

  • Replace signInWithRedirect with signInWithPopup in the useAuth hook.
  • Update config.js with the Firebase config keys.

Testing Steps / QA Criteria

  1. Ensure config.js is updated with the correct Firebase config keys (from here: https://the-collab-lab.slack.com/archives/C0172ED75DL/p1723028088608819?thread_ts=1723027971.748089&cid=C0172ED75DL)
  2. Ensure signInWithRedirect has been replaced with signInWithPopup in the useAuth hook.

- Replace signInWithRedirect with signInWithPopup in the useAuth hook
@ahsanatzapier ahsanatzapier self-assigned this Aug 9, 2024
Copy link
Member

@deeheber deeheber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thank you!

@ahsanatzapier ahsanatzapier merged commit 1d0bc86 into main Aug 9, 2024
1 check passed
@deeheber deeheber deleted the update-firebase-auth branch August 9, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants