Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Danielle to contributors #17

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Add Danielle to contributors #17

merged 1 commit into from
Aug 9, 2024

Conversation

deeheber
Copy link
Member

@deeheber deeheber commented Aug 9, 2024

Description

Adding myself to the contributors. The directions say we can commit directly to the main branch; however, I made some tweaks to our firebase setup and wanted to make sure the CI still works.

Copy link

github-actions bot commented Aug 9, 2024

Visit the preview URL for this PR (updated for commit d523cf7):

https://tcl-75-smart-shopping-list--pr17-add-danielle-llbrjsk8.web.app

(expires Fri, 16 Aug 2024 23:31:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1f1fd53c369e1fa31e15c310aa075b4e8f4f8dde

@deeheber
Copy link
Member Author

deeheber commented Aug 9, 2024

Confirming that the pr preview link got added to authorized domains and that the CI passes. The Oauth overlords will be pleased.
Screenshot 2024-08-09 at 16 32 41

Normally we would want to get PR approval before merging, but for now this will be a one time exception.

@deeheber deeheber merged commit 71787ef into main Aug 9, 2024
3 checks passed
@deeheber deeheber deleted the add-danielle branch August 9, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant