Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ahsan Hassan as a mentor #18

Merged
merged 1 commit into from
Aug 10, 2024
Merged

Conversation

ahsanatzapier
Copy link
Collaborator

Description

In this PR, ahsan is added to CONTRIBUTORS.md in line with the steps provided here: https://github.com/the-collab-lab/tcl-75-smart-shopping-list?tab=readme-ov-file#make-your-first-contribution

Acceptance Criteria

  • Ahsan is in the file with the link to the GitHub repo

Type of Changes

enhancement

Updates

Before

Ahsan was not in the CONTRIBUTORS file.

After

Ahsan is in the CONTRIBUTORS fire.

Testing Steps / QA Criteria

  • Verify that Ahsan appears in the CONTRIBUTORS file.

Copy link

Visit the preview URL for this PR (updated for commit 4bcda13):

https://tcl-75-smart-shopping-list--pr18-adding-ahsan-to-cont-vh8fhxvu.web.app

(expires Sat, 17 Aug 2024 06:58:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1f1fd53c369e1fa31e15c310aa075b4e8f4f8dde

Copy link
Member

@deeheber deeheber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that I can see your name in the CONTRIBUTORS file and that you followed the directions.

@ahsanatzapier ahsanatzapier merged commit 021c08d into main Aug 10, 2024
2 checks passed
@ahsanatzapier ahsanatzapier deleted the adding-ahsan-to-contributor branch August 10, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants