Revert "Issue 1" #19
Merged
Revert "Issue 1" #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit ce4faf8): https://tcl-75-smart-shopping-list--pr19-dh-revert-issue-1-mwkvr28v.web.app (expires Sat, 17 Aug 2024 20:30:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1f1fd53c369e1fa31e15c310aa075b4e8f4f8dde |
deeheber
commented
Aug 10, 2024
| @@ -1,8 +1,7 @@ | |||
| /* eslint-disable jsx-a11y/anchor-is-valid */ | |||
There was a problem hiding this comment.
This was needed bc the git hooks did not let me commit.
Once the issue 3 is complete we can guide the collabies to delete this.
There was a problem hiding this comment.
Thanks for adding this!
ahsanatzapier
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an example of how to fill this template out, see this Pull Request.
Description
It appears this repo was initialized with issue 1 completed. Thanks for pointing this out @ahsanatzapier!
Related Issue
1
Acceptance Criteria
As mentors, we need to be able to demo pair programming at our first sync using issue 1 as an example. In order to do so, the code to complete issue 1 should not be present.
Type of Changes
Removing the code to complete issue 1.
Updates
Before
Before the code to complete issue 1 (show sign in and sign out buttons) was there.
After
After the code to complete issue 1 is gone. the sign in and sign out buttons should not be visible or present on the page.
Testing Steps / QA Criteria
npm starthttp://localhost:3000/