Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
useAuth
to usesignInWithPopup
instead ofsignInWithRedirect
, but the comment wasn't updated.Acceptance Criteria
SignInButton
reflects the actual behavior of the sign-in workflow.Type of Changes
documentation
Updates
Before
SignInButton
comment stated user would be redirected to sign-in.After
SignInButton
comment states a popup will open for the sign-in.Testing Steps / QA Criteria
SignInButton
opens a popup for Google OAuth sign-in and successfully signs in the user, closing the popup after the process.