Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment for SignInButton #20

Merged
merged 1 commit into from
Aug 11, 2024
Merged

Conversation

ahsanatzapier
Copy link
Collaborator

Description

  • We updated useAuth to use signInWithPopup instead of signInWithRedirect, but the comment wasn't updated.
  • This pull request updates the comment.

Acceptance Criteria

  • Comment for SignInButton reflects the actual behavior of the sign-in workflow.

Type of Changes

documentation

Updates

Before

  • SignInButton comment stated user would be redirected to sign-in.

After

  • SignInButton comment states a popup will open for the sign-in.

Testing Steps / QA Criteria

  • Verify that the comment reflects the accurate behavior of the sign-in flow.
  • Ensure the SignInButton opens a popup for Google OAuth sign-in and successfully signs in the user, closing the popup after the process.

Copy link
Member

@deeheber deeheber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this.

Copy link

Visit the preview URL for this PR (updated for commit a10a758):

https://tcl-75-smart-shopping-list--pr20-useauth-comments-upd-wal2gs1t.web.app

(expires Sun, 18 Aug 2024 17:21:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1f1fd53c369e1fa31e15c310aa075b4e8f4f8dde

@ahsanatzapier ahsanatzapier merged commit f607773 into main Aug 11, 2024
2 checks passed
@ahsanatzapier ahsanatzapier deleted the useAuth-comments-update branch August 11, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants