Repository navigation
Escape the comment-page value in the single-post breadcrumb (reflected XSS) - #148
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The npm package metadata still reports older versions than the new 1.6.14 theme release.
1 open finding
What changed in this PR
This PR prevents reflected XSS in the single-post breadcrumb by converting the cpage query value to an integer before displaying it.
Changes:
- Cast the comment-page value with
absint()before rendering the breadcrumb. - Add a 1.6.14 changelog entry and update the theme version headers.
| File | Description |
|---|---|
| style.css | Updates the theme version header. |
| sass/style.scss | Updates the Sass source version header. |
| readme.txt | Documents the security fix. |
| inc/estore.php | Constrains the displayed comment-page value to an integer. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| Author URI: https://www.themegrill.com | ||
| Description: eStore is a clean, beautiful and fully customizable responsive WooCommerce WordPress theme. This theme packs many premium features and several custom widgets which helps making your online store professional and well organized. Theme is fully compatible with WooCommerce and YITH WooCommerce Wishlist plugins. As an online store owner, attracting customers and selling products will be lot easier with this theme. Check the demo here: https://themegrilldemos.com/estore/ and get free support here: https://wordpress.org/support/theme/estore/ | ||
| Version: 1.6.13 | ||
| Version: 1.6.14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.