Hide double/long press action in Home app when disabled (#143) #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [jsonwebtoken](https://github.com/auth0/node-jsonwebtoken) to 9.0.2 and updates ancestor dependency [homebridge-config-ui-x](https://github.com/homebridge/homebridge-config-ui-x). These dependencies need to be updated together. Updates `jsonwebtoken` from 8.5.1 to 9.0.2 - [Changelog](https://github.com/auth0/node-jsonwebtoken/blob/master/CHANGELOG.md) - [Commits](auth0/node-jsonwebtoken@v8.5.1...v9.0.2) Updates `homebridge-config-ui-x` from 4.50.5 to 4.53.0 - [Release notes](https://github.com/homebridge/homebridge-config-ui-x/releases) - [Changelog](https://github.com/homebridge/homebridge-config-ui-x/blob/latest/CHANGELOG.md) - [Commits](homebridge/homebridge-config-ui-x@4.50.5...4.53.0) --- updated-dependencies: - dependency-name: jsonwebtoken dependency-type: indirect - dependency-name: homebridge-config-ui-x dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
dominick-han
commented
Dec 27, 2023
|
I thiiiiiiink it’s a HomeKit issue, where characteristic existence/absence is immutable after instantiation (but I’m not an authority) |
|
Sooo, should we add a message in the webpage saying if user enable/disables long/double click, they should remove it from cache and re-generate? |
|
@dominick-han thoughts on #157 |
donavanbecker
force-pushed
the
main
branch
7 times, most recently
from
7f50643 to
0cbdbab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only add DOUBLE_PRESS/LONG_PRESS to ProgrammableSwitchEvent's validValues when the option(s) are enabled
Tested locally on all 4 scenarios
One issue: When changing between enabled/disabled, user needs to delete the accessary cache on Homebridge web UI, then restart the bridge. User will lose existing settings
(Might look into this later)