Skip to content

Commit

Permalink
Merge pull request #19 from theogf/fix_download_pdf
Browse files Browse the repository at this point in the history
Fix `download_pdf`
  • Loading branch information
theogf authored Feb 10, 2022
2 parents 74ea677 + 4648446 commit 8fe529b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Remarkable"
uuid = "4ac160eb-0277-4e02-b3c6-a4c4623dd812"
authors = ["Theo Galy-Fajou <[email protected]> and contributors"]
version = "0.1.2"
version = "0.1.3"

[deps]
AbstractTrees = "1520ce14-60c1-5f80-bbc7-55ef81b5835c"
Expand Down
2 changes: 1 addition & 1 deletion src/api.jl
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ function download_pdf(
isempty(title(doc)) ? doc.ID : (ispdf(doc) ? title(doc)[1:(end - 4)] : title(doc))
z = ZipFile.Reader(file_path)
for f in z.files
if endswith(f, ".pdf")
if endswith(f.name, ".pdf")
write(joinpath(path_target, file_name * ".pdf"), f)
@info "Extracted $(file_name).pdf"
return joinpath(path_target, file_name * ".pdf")
Expand Down

2 comments on commit 8fe529b

@theogf
Copy link
Owner Author

@theogf theogf commented on 8fe529b Feb 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/54360

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.1.3 -m "<description of version>" 8fe529bc68cf5b68067a7df3ef8e0513510651e8
git push origin v0.1.3

Please sign in to comment.