Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed linktest executable #1107

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

sss-create
Copy link
Collaborator

@sss-create sss-create commented Jan 18, 2025

This would resolve issue #1041.... I just don't know if this would break anything. I assume it won't but still.. -- hence the PR and no direct push. 😶‍🌫️

@sss-create sss-create requested a review from yaxu January 18, 2025 22:08
@yaxu
Copy link
Member

yaxu commented Jan 18, 2025

I don't see why this would be a problem, but @Zalastax will be more familiar with it

@yaxu
Copy link
Member

yaxu commented Jan 18, 2025

BTW I think best we do PRs for everything anyway, even when you merge yourself, not least because it makes release notes easier.

@sss-create
Copy link
Collaborator Author

Ok, got it :)

While we're at it: Do we need to host the Ableton Link code ourselves here or could we reference the ableton repo as a submodule (with a specific commit)? Maybe @Zalastax can answer this too.

@Zalastax
Copy link
Collaborator

The renaming should be fine.

I used submodules originally but we changed to use file copy: #891 (comment)

I don't see much benefit to change back to submodules but I think it might be time to update the files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants