Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

understand voicings page #1230

Merged
merged 8 commits into from
Jan 18, 2025
Merged

understand voicings page #1230

merged 8 commits into from
Jan 18, 2025

Conversation

felixroos
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@daslyfe daslyfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!! It will be much easier to teach now

Copy link

@TodePond TodePond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very helpful and interesting!

i followed through and noted down and questioned I had along the way.

  • I didn't understand what you meant by "the voicings will be automatically generated with smooth voice leading" but then you got to it later on and it was fine. maybe adding a "(more on this later)" or something would have helped me to keep going.
  • when you say "- ^ is the same as M, for example C^7 = CM7", I assume that C7 is also the same? or am I wrong?

do whatever you want with this user test, thanks for the write up :)

@felixroos
Copy link
Collaborator Author

felixroos commented Dec 26, 2024

thanks for the feedback!

I've tweaked a few sentences to hopefully make it clearer.

when you say "- ^ is the same as M, for example C^7 = CM7", I assume that C7 is also the same? or am I wrong?

this is indeed a bit confusing, but unfortunately the "norm": C^ = CM = C . but C^7 !== C7
C^7 = C E G B but C7 = C E G Bb or generally "^7" = 0 4 7 11 and "7" = 0 4 7 10 .
It might make sense to add a little bit more theoretical background about where these chord symbols come from / what they mean.

@bwagner
Copy link
Contributor

bwagner commented Dec 26, 2024

Thank you, @felixroos, for your answer on discord about how to implement Drop2-voicings!

Maybe it helps to understand if the voicing dictionary in the example would be broken down:

addVoicings('house', {
'': ['7 12 16', '0 7 16', '4 7 12'],
'm': ['0 3 7']
})

The first key is the default (empty string), hence the major triad.
The provided voicings for the first of three voicings of the major triad are:
7 = 7 half steps = pure 5th
12 = 12 half steps = pure octave
16 = 16 half steps = octave above major third

I guess the order of these offsets is irrelevant to the result since they'll sound simultaneously. Still, this might be worth mentioning.

suggested changes to voicings.mdx
@felixroos felixroos marked this pull request as ready for review January 18, 2025 22:26
@felixroos felixroos merged commit 8d28317 into main Jan 18, 2025
2 checks passed
@felixroos felixroos deleted the voicings-doc branch January 18, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants