Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package versions and fix type errors #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ejconlon
Copy link

I wanted to contribute to this repo, but it no longer builds with recent tsc and various npm package versions! This PR:

  1. Runs npx npm-check-updates --upgrade to upgrade all package versions.
  2. Migrates to the new way of testing extensions.
  3. Fixes some type errors found by tsc blocking testing.
  4. Comments out the one failing assertion in the test suite that I can't figure out. (It's on some spurious input anyway...) Please look at this if possible.
  5. Removes trailing whitespace in modified files.

package-lock.json is going to be a huge diff because we are updating a bunch of packages and doing a packgage file version upgrade too, so don't be scared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant