demo song optimization #1534
Merged
demo song optimization #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to sleep now..... Don't merge yet. |
|
Why did you not create a branch in this repo......................... I wanted to make the process easier... |
|
Beware when converting from 8/16 to YMZ ADPCM. The pitch range of YMZ ADPCM samples is less. |
|
@freq-mod, have you also run pattern deduplication and reorder on all demo songs? Of course, most probably it's already done, but if we are not sure that any song went through this, we need to do it for all songs. It may not save megabytes, but cumulative effect can go up to around 50 KiB for all songs combined. Of course, if each demo song went through this before being added, it's not needed. |
|
I haven't, since I dont think it will save more than few kilobytes per song. |
tildearrow
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
16-bit PCM -> more sensible, native formats. Total size reduction - 1.5 MB