Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ABI test against PG snapshot #7457

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

kpan2034
Copy link
Contributor

@kpan2034 kpan2034 commented Nov 19, 2024

This adds a test to check the ABI compatibility with PG snapshot. Timescaledb is built against the mininum abi version of postgres supported, for each major version of PG and tested against the latest snapshot.

Disable-check: force-changelog-file

@kpan2034 kpan2034 self-assigned this Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.19%. Comparing base (59f50f2) to head (bcb9306).
Report is 652 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7457      +/-   ##
==========================================
+ Coverage   80.06%   82.19%   +2.12%     
==========================================
  Files         190      230      +40     
  Lines       37181    43252    +6071     
  Branches     9450    10875    +1425     
==========================================
+ Hits        29770    35552    +5782     
- Misses       2997     3380     +383     
+ Partials     4414     4320      -94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kpan2034 kpan2034 force-pushed the add-abi-test branch 6 times, most recently from de3209e to 72ab951 Compare November 19, 2024 23:10
@kpan2034 kpan2034 force-pushed the add-abi-test branch 3 times, most recently from 745db2e to 2d40581 Compare November 26, 2024 01:16
@kpan2034 kpan2034 marked this pull request as ready for review November 26, 2024 01:16
@kpan2034
Copy link
Contributor Author

The added workflow ABI Test Against Snapshot currently fails for PG15, PG16, and PG17 for the hypercore and hypercore_create tests.

This is due to the warnings like the following being thrown, which break our tests:

WARNING:  missing lock for relation "_hyper_1_1_chunk" (OID 17160, relkind r) @ TID (16,27)

Copy link
Member

@svenklemm svenklemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are building pg twice in the workflow while technically we only need to build it once. But since this only runs nightly and it would probably complicate the workflow a bit I think this is fine.

@kpan2034 kpan2034 force-pushed the add-abi-test branch 2 times, most recently from e39dc0c to d439cab Compare December 12, 2024 20:05
This adds a test to check the ABI compatibility with PG snapshot.
Timescaledb is built against the mininum abi version of postgres
supported, for each major version of PG and tested against the latest
snapshot.
@kpan2034 kpan2034 enabled auto-merge (squash) December 12, 2024 21:31
@kpan2034 kpan2034 disabled auto-merge December 13, 2024 19:26
@kpan2034 kpan2034 enabled auto-merge (squash) December 13, 2024 19:27
@kpan2034 kpan2034 merged commit ed7b36c into timescale:main Dec 13, 2024
56 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants