Apply sort transform optimizations to compressed chunks #7528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we transform sorting by `time_bucket` to sorting by `time` only for uncompressed chunks. Implement it for the compressed chunks as well.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7528 +/- ##
==========================================
+ Coverage 80.06% 82.22% +2.15%
==========================================
Files 190 231 +41
Lines 37181 43413 +6232
Branches 9450 10923 +1473
==========================================
+ Hits 29770 35697 +5927
- Misses 2997 3391 +394
+ Partials 4414 4325 -89 ☔ View full report in Codecov by Sentry. |
This reverts commit c401f44.
svenklemm
reviewed
Dec 21, 2024
svenklemm
approved these changes
Dec 21, 2024
This reverts commit 665418f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we transform sorting by
time_bucketto sorting bytimeonly for uncompressed chunks. Implement it for the compressed chunks as well.In tsbench, some queries are up to 770x faster:
https://grafana.ops.savannah-dev.timescale.com/d/fasYic_4z/compare-akuzm?orgId=1&var-branch=All&var-run1=3997&var-run2=3998&var-threshold=0.02&var-use_historical_thresholds=true&var-threshold_expression=2%20%2A%20percentile_cont%280.90%29&var-exact_suite_version=false&from=now-2d&to=now
Should improve the query plans in this issue: #6310