-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NULL handling for in-memory tuple filtering #7557
Conversation
afdceb5
to
02422fe
Compare
02422fe
to
21ba503
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7557 +/- ##
==========================================
+ Coverage 80.06% 82.21% +2.14%
==========================================
Files 190 231 +41
Lines 37181 43380 +6199
Branches 9450 10911 +1461
==========================================
+ Hits 29770 35665 +5895
- Misses 2997 3392 +395
+ Partials 4414 4323 -91 ☔ View full report in Codecov by Sentry. |
21ba503
to
4277e28
Compare
int cur_nkeys = nkeys; | ||
ScanKey cur_key = keys; | ||
|
||
for (; cur_nkeys--; cur_key++) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is some creative for loop 😅
4277e28
to
c888d7a
Compare
During DML decompression, we filter out batches that don't need decompression using in-memory filtering which filters compressed tuples using scankeys. Those scankeys were not detecting NULL values correctly for unique constraints which use NULLS NOT DISTINCT setting. This change uses existing codebase to properly detect those tuples when using SK_ISNULL flag.
c888d7a
to
a488025
Compare
Automated backport to 2.17.x not done: cherry-pick failed. Git status
|
During DML decompression, we filter out batches that don't need decompression using in-memory filtering which filters compressed tuples using scankeys. Those scankeys were not detecting NULL values correctly for unique constraints which use NULLS NOT DISTINCT setting. This change uses existing codebase to properly detect those tuples when using SK_ISNULL flag.