Move function from under a wrong ifdef #7564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow the hypercore supported am function ended up under #ifdef TELEMETRY, so some rare build configurations are failing.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7564 +/- ##
==========================================
+ Coverage 80.06% 82.24% +2.17%
==========================================
Files 190 231 +41
Lines 37181 43380 +6199
Branches 9450 10911 +1461
==========================================
+ Hits 29770 35679 +5909
- Misses 2997 3383 +386
+ Partials 4414 4318 -96 ☔ View full report in Codecov by Sentry. |
fabriziomello
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow the hypercore supported am function ended up under
#ifdef TELEMETRY, so some rare build configurations are failing.
Disable-check: force-changelog-file
Since this is a cosmetic change in Hypercore:
Disable-check: approval-count