Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Postgres uint64 instead of the C uint64_t #7573

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

akuzm
Copy link
Member

@akuzm akuzm commented Jan 7, 2025

They are nominally different on some platforms (e.g. unsigned long vs unsigned long long), so we shouldn't mix them.

Disable-check: force-changelog-file

Since this is a trivial CI fix:
Disable-check: approval-count

They are nominally different on some platforms (e.g. unsigned long vs
unsigned long long), so we shouldn't mix them.
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.22%. Comparing base (59f50f2) to head (6d0be0a).
Report is 679 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7573      +/-   ##
==========================================
+ Coverage   80.06%   82.22%   +2.15%     
==========================================
  Files         190      238      +48     
  Lines       37181    43716    +6535     
  Branches     9450    10968    +1518     
==========================================
+ Hits        29770    35945    +6175     
- Misses       2997     3433     +436     
+ Partials     4414     4338      -76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akuzm akuzm enabled auto-merge (squash) January 7, 2025 14:57
@akuzm akuzm merged commit 6ce35d7 into timescale:main Jan 7, 2025
137 of 142 checks passed
@akuzm akuzm deleted the uint64_t branch January 7, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants